Skip to content

Conversation

@harr1424
Copy link
Contributor

@harr1424 harr1424 commented Dec 31, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30221?atlOrigin=eyJpIjoiMjlmYzM2ODRmZGIxNDcxY2FhNmI1YmFkNTgyNjgxYTMiLCJwIjoiaiJ9

https://bitwarden.atlassian.net/browse/PM-30313?atlOrigin=eyJpIjoiODI4MDY3MGNjZWU4NGU0NzgyYzJiZDZjMDZhZWZhMjIiLCJwIjoiaiJ9

https://bitwarden.atlassian.net/browse/PM-30322?atlOrigin=eyJpIjoiMDM3MDBmZjY3Mjk1NDM2Y2EyMWFiMmI1OWRkZjQ5YTUiLCJwIjoiaiJ9

📔 Objective

This PR consolidates three objectives:

  1. The SendAuthenticationQuery has been modified to use the AuthType property previously added to the Send object in order to determine authentication strategy
  2. Two new endpoints have been added to SendsController that will direct text and file based send access authentication to logic implemented by the Auth Team
  3. A third endpoint has been added allowing the removal of email OTP and password based authentication

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

audreyality and others added 30 commits May 28, 2025 14:31
This reverts commit 7df56e3.

undo migrations removal
@harr1424 harr1424 removed the ai-review Request a Claude code review label Jan 6, 2026
@harr1424 harr1424 marked this pull request as ready for review January 6, 2026 15:46
@harr1424 harr1424 requested a review from a team as a code owner January 6, 2026 15:46
@harr1424 harr1424 marked this pull request as draft January 6, 2026 16:47
@harr1424 harr1424 marked this pull request as ready for review January 6, 2026 23:19
itsadrago
itsadrago previously approved these changes Jan 7, 2026
mcamirault
mcamirault previously approved these changes Jan 9, 2026
Copy link
Contributor

@mcamirault mcamirault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One ❓(non-blocking), do you want to remove the tools-send-email-otp-listing feature flag in this PR as well since you've removed all its usages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants