-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Tools] Update SendAuthenticationQuery, add new non-anonymous endpoints, and add PutRemoveAuth endpoint #6786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harr1424
wants to merge
56
commits into
main
Choose a base branch
from
tools/PM-30221-Update-SendAuthenticationQuery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+842
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7df56e3. undo migrations removal
itsadrago
previously approved these changes
Jan 7, 2026
mcamirault
previously approved these changes
Jan 9, 2026
Contributor
mcamirault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One ❓(non-blocking), do you want to remove the tools-send-email-otp-listing feature flag in this PR as well since you've removed all its usages?
mcamirault
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-30221?atlOrigin=eyJpIjoiMjlmYzM2ODRmZGIxNDcxY2FhNmI1YmFkNTgyNjgxYTMiLCJwIjoiaiJ9
https://bitwarden.atlassian.net/browse/PM-30313?atlOrigin=eyJpIjoiODI4MDY3MGNjZWU4NGU0NzgyYzJiZDZjMDZhZWZhMjIiLCJwIjoiaiJ9
https://bitwarden.atlassian.net/browse/PM-30322?atlOrigin=eyJpIjoiMDM3MDBmZjY3Mjk1NDM2Y2EyMWFiMmI1OWRkZjQ5YTUiLCJwIjoiaiJ9
📔 Objective
This PR consolidates three objectives:
SendAuthenticationQueryhas been modified to use theAuthTypeproperty previously added to theSendobject in order to determine authentication strategySendsControllerthat will direct text and file based send access authentication to logic implemented by the Auth Team⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes