Skip to content

Conversation

@r-tome
Copy link
Contributor

@r-tome r-tome commented Nov 21, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28252

📔 Objective

Add a feature flag for increasing bulk reinvite limit for cloud from 500 to 4,000.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Logo
Checkmarx One – Scan Summary & Details096c4a7a-dc0b-4c6e-9a8c-5c503de35a8b

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.08%. Comparing base (fdfec0a) to head (22d1b0c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6624   +/-   ##
=======================================
  Coverage   53.08%   53.08%           
=======================================
  Files        1899     1899           
  Lines       84593    84593           
  Branches     7604     7604           
=======================================
  Hits        44902    44902           
  Misses      37942    37942           
  Partials     1749     1749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@r-tome r-tome requested review from a team and jrmccannon November 21, 2025 16:50
@r-tome r-tome marked this pull request as ready for review November 21, 2025 16:50
@claude
Copy link
Contributor

claude bot commented Nov 21, 2025

Claude finished @r-tome's task —— View job


Code Review Complete

  • Examine the code changes
  • Evaluate PR title and description
  • Review code quality and best practices
  • Post comprehensive review feedback

Summary

This PR adds a single feature flag constant (IncreaseBulkReinviteLimitForCloud) to FeatureFlagKeys in Constants.cs. The change is minimal and follows existing patterns. However, there is a ticket number discrepancy that needs attention.

Findings

Finding 1: Ticket number mismatch between feature flag name and PR/Jira reference

💭 The feature flag is named pm-28251-increase-bulk-reinvite-limit-for-cloud (line 146), but the PR title, description, and Jira link all reference PM-28252. Which ticket number is correct?

  • If PM-28252 is correct, the flag should be: "pm-28252-increase-bulk-reinvite-limit-for-cloud"
  • If PM-28251 is correct, the PR title and Jira link need updating

Finding 2: Feature flag appears unused in this PR

⚠️ The feature flag is defined but not consumed anywhere in this codebase. I searched for usage in OrganizationUsersController.cs and ProviderUsersController.cs (where bulk reinvite logic would likely exist), but found no references to this flag.

Questions:

  • Is this flag intended to be used in a follow-up PR?
  • Should this PR include the actual implementation that uses the flag?

Per the project's CLAUDE.md: "Feature flags considered for new features" - this follows that practice, but typically flags are defined alongside their usage.

Good Practices Observed

  • Follows existing naming convention for feature flags (team-jira-description format)
  • Placed in correct section (Admin Console Team)
  • Alphabetically ordered within the section

Action Items

  1. Resolve ticket number discrepancy (Finding 1) - either update the constant value or PR/Jira references
  2. Clarify implementation plan (Finding 2) - confirm whether this is intentionally defined ahead of usage or if implementation should be included

@r-tome r-tome merged commit fcc879b into main Nov 24, 2025
40 of 41 checks passed
@r-tome r-tome deleted the ac/pm-28252/increase-bulk-reinvite-limit-for-cloud branch November 24, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants