Skip to content

Conversation

@amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

📔 Objective

This PR removes the pm-21821-provider-portal-takeover feature flag, which is on in Live, enshrining Provider Portal disablement for unpaid provider subscriptions.

Additionally, it removes a manual disablement mechanism via applying metadata to a provider's subscription directly since that is no longer used.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner November 20, 2025 20:50
@claude
Copy link
Contributor

claude bot commented Nov 20, 2025

Claude Code is working…

I'll analyze this and get back to you.

View job run

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Logo
Checkmarx One – Scan Summary & Details1f48b0fd-4ab7-4141-abbd-4270350ea104

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 53.40%. Comparing base (b3573c1) to head (eed0fdc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ices/Implementations/SubscriptionUpdatedHandler.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6613      +/-   ##
==========================================
- Coverage   57.24%   53.40%   -3.85%     
==========================================
  Files        1910     1910              
  Lines       85156    85127      -29     
  Branches     7651     7644       -7     
==========================================
- Hits        48748    45459    -3289     
- Misses      34576    37912    +3336     
+ Partials     1832     1756      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kdenney
kdenney previously approved these changes Nov 21, 2025
Copy link
Collaborator

@sbrown-livefront sbrown-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amorask-bitwarden amorask-bitwarden merged commit 71be386 into main Dec 2, 2025
44 of 45 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/PM-24558/remove-ff_pm-21821-provider-portal-takeover branch December 2, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants