Migrate folder create and edit #340
Conversation
…ient-managed-tokens
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 71.63% 72.12% +0.48%
==========================================
Files 239 244 +5
Lines 19354 19853 +499
==========================================
+ Hits 13865 14318 +453
- Misses 5489 5535 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| bitwarden-sm = { path = "bitwarden_license/bitwarden-sm", version = "=1.0.0" } | ||
| bitwarden-ssh = { path = "crates/bitwarden-ssh", version = "=1.0.0" } | ||
| bitwarden-state = { path = "crates/bitwarden-state", version = "=1.0.0" } | ||
| bitwarden-test = { path = "crates/bitwarden-test", version = "=1.0.0" } | ||
| bitwarden-threading = { path = "crates/bitwarden-threading", version = "=1.0.0" } |
There was a problem hiding this comment.
I thought we were running cargo sort to check the order here, I wonder how these went through initially
|
|
||
| #[cfg_attr(feature = "wasm", wasm_bindgen)] | ||
| impl FoldersClient { | ||
| #[allow(missing_docs)] |
There was a problem hiding this comment.
Can we add some docs to these functions?
| let folder: Folder = resp.try_into()?; | ||
|
|
||
| repository | ||
| .set(require!(folder.id).to_string(), folder.clone()) |
There was a problem hiding this comment.
You could slightly simplify this by using the provided folder id:
| .set(require!(folder.id).to_string(), folder.clone()) | |
| .set(folder_id.to_string(), folder.clone()) |
Should we also add a debug assert to make sure the id returned by the api matches the provided one?
debug_assert_eq!(folder_id, &folder.id.to_string());
🎟️ Tracking
📔 Objective
Fully migrate folder create and edit to the SDK to demonstrate the repository and api capabilities.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes