Expose credential exchange in wasm #222
Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 67.05% 67.03% -0.02%
==========================================
Files 212 213 +1
Lines 15989 15993 +4
==========================================
Hits 10721 10721
- Misses 5268 5272 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| impl ExporterClient { | ||
| /// Constructs a new SDK client for exporting and importing vault items. | ||
| pub fn new(client: Client) -> Self { |
There was a problem hiding this comment.
This doesn't seem used anywhere. We need to create an exporter function on crates/bitwarden-wasm-internal/src/client.rs to return the exporter client so that it can be created in WASM
There was a problem hiding this comment.
Alternatively, you may be able to add this to the WASM client file:
pub fn exporters(&self) -> bitwarden_exporters::ExporterClient {
bitwarden_exporters::ExporterClient::new(self.0.clone())
}
and remove this file entirely if the API in bitwarden-exporters is the same?
There was a problem hiding this comment.
Ah true. I changed to exposing the ExporterClient directly.
|
🎟️ Tracking
📔 Objective
We would like to do a PoC where we implement credential exchange in our browser extension. Which requires us to expose the CXF flow in wasm.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes