[BEEEP/POC] Noise IPC CryptoProvider #219
Draft
+498
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Adds a cryptoprovider implementation for the IPC channel based on NOISE / snow (https://github.com/mcginty/snow). Currently we use the default, non-post-quantum protocol suite, but snow even has compile-time support for PQ ciphers.
The wire format specifically accounts for us later switching away from Noise. This is not planned, but in the past this came to bite us, so in this case the wire format (but not the rest of the structures / impls) account for multiple crypto implementations.
Further, ciborium/cbor is used for encoding. This is a transitive dependency of cose aswell and simply more efficient than json.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes