Skip to content

[PM-19479] POC state traits #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[PM-19479] POC state traits #213

wants to merge 2 commits into from

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Apr 15, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19479

📔 Objective

Implement a generic trait for accessing the application's data storage directly. Because we want the store access to be typed, but bitwarden_core isn't aware of the models, bitwarden_core only implements a generic way to set and retrieve generic impl DataStore<T> instances. Then it's up to each team/feature crates to define which models and which stores are available.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 71.96765% with 104 lines in your changes missing coverage. Please review.

Project coverage is 67.23%. Comparing base (8f0ea14) to head (778bc50).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-uniffi/src/platform/mod.rs 0.00% 35 Missing ⚠️
...es/bitwarden-ffi-macros/src/extern_wasm_channel.rs 90.55% 22 Missing ⚠️
crates/bitwarden-wasm-internal/src/client.rs 0.00% 20 Missing ⚠️
crates/bitwarden-core/src/client/data_store.rs 77.04% 14 Missing ⚠️
crates/bitwarden-core/src/client/internal.rs 0.00% 12 Missing ⚠️
crates/bitwarden-ffi-macros/src/lib.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   67.11%   67.23%   +0.12%     
==========================================
  Files         211      214       +3     
  Lines       15975    16346     +371     
==========================================
+ Hits        10721    10991     +270     
- Misses       5254     5355     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Logo
Checkmarx One – Scan Summary & Details1a31a346-aec3-4dd4-b3de-79429e25ce36

Great job, no security vulnerabilities found in this Pull Request

@dani-garcia dani-garcia changed the title POC state traits [PM-19479] POC state traits Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant