-
Notifications
You must be signed in to change notification settings - Fork 12
[Innovation-Sprint/PM-19065] Add opaque authentication / unlock #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
quexten
wants to merge
28
commits into
main
Choose a base branch
from
innovation/opaque
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+964
โ3
Draft
Changes from 13 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
582854f
Add opaque
quexten d6ba83b
Add login
quexten c17a752
Make tsify optional
quexten 116ab8b
Add errors to opaque
quexten 24fff58
Cargo fmt
quexten a82287a
Fix build
quexten 29eb7ed
Fix formatting
quexten bc17bf0
Add encryption
quexten 697f9aa
Add rotateable keyset
quexten 8cfef9b
Update formatting
quexten c89c0eb
Cargo fmt
quexten 2b1cb0e
Formatting
quexten 435d6bf
Merge branch 'main' into innovation/opaque
quexten 33ddf6a
Fix formatting
quexten 27aadef
Fix clippy warning
quexten 27f94e1
Fix clippy
quexten 8796b4f
Fix clippy warning
quexten 06c759e
Add tests
quexten cc36109
Add test for login finish
quexten 7da2f7b
More tests, separate decryption of keyset
quexten f1bd00c
Cleanup
quexten d9964a9
Format
quexten b9fa0e9
Fix tests
quexten 83b1218
Rename
quexten 7cdfcae
Fix exported type
quexten a2e7e4f
Cleanup structure
quexten 7c74150
Merge branch 'main' into innovation/opaque
quexten 6155e1d
Merge branch 'main' into innovation/opaque
quexten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue: These does not follow https://contributing.bitwarden.com/architecture/sdk/dependencies/#explicit-ranges |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,3 +24,4 @@ pub use kdf::{ | |
default_pbkdf2_iterations, Kdf, | ||
}; | ||
mod utils; | ||
pub(crate) use utils::stretch_key; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: There seems to be little reason to use the client at all here since it's just obfuscating direct calls to types?
This is related to my comment about
CipherConfiguration
leaking sensitive values.