Repository navigation
Update SDK to 895ee2e (3.0.0-8168-8be9dbc) - #2989
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2989 +/- ##
==========================================
+ Coverage 79.97% 80.00% +0.02%
==========================================
Files 1171 1171
Lines 75894 75974 +80
==========================================
+ Hits 60696 60780 +84
+ Misses 15198 15194 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Claude finished @bw-ghapp[bot]'s task in 5m 50s —— View job SDK bump evaluated
Surface delta: 12 removed, 71 added, 0 mutated type declarations. Version comment matches Compile-time breaksBuild passed — Three source-level breaks were in range, and all three already carry fixes in this PR's own commits — nothing left to resolve:
Both Runtime considerations
Everything else in range — confirmed safe
CommitNo commit — nothing needed fixing. The three compile-time breaks in range were already resolved by commits on this branch, and the baseline build passes clean on both schemes. |
The SDK now populates `MasterPasswordUnlockData.containedKeyId` from the user key, and its own request-model conversion forwards it. iOS builds `MasterPasswordUnlockDataRequestModel` by hand, so it was dropping the field and sending no key ID for users whose key has one — the case bitwarden/sdk-internal#1391 set out to fix.
Updates the SDK from
b7e7be7e7f5adde3cafcb27d79fac80a53c5c3c8to895ee2eff3228ee310f6c894bed0a7b14ba9fd65Objective
Compile-time breaks
(check more info in Claude's comment below)
Build passed —
build-for-testingon bothBitwardenandAuthenticatorexits 0 against the resolved895ee2echeckout (verified inbuild/DerivedData/SourcePackages/workspace-state.json).Three source-level breaks were in range, and all three already carry fixes in this PR's own commits — nothing left to resolve:
Client.initgained requiredmanagedSettings: ManagedSettingsBindingClientBitwardenShared/Core/Platform/Services/ClientBuilder.swift:73-77,AuthenticatorShared/Core/Platform/Services/ClientService.swift:290-294Send.data: SendItem?/SendView.data: SendItemView?added to both initializersBitwardenSdk+Tools.swift,BitwardenSdk+ToolsFixtures.swift,SendView+Fixtures.swift,SendListState+Fixtures.swift,AddEditSendItemState.swiftMasterPasswordUnlockData.containedKeyId: KeyId?addedMasterPasswordUnlockDataRequestModel.swift:11,34,54(+UpdateKdfRequestTests,AccountAPIServiceTests)Both
managedSettingsfixes pass a freshManagedSettingsBindingClient()with a comment explaining that PM reads MDM config from thecom.apple.configuration.manageddefaults domain inEnvironmentServiceinstead — correct for iOS, which does not consume the SDK's managed-settings channel.What's Changed
UserCryptoManagementClient.within_v2_migration_grace_periodmethod sdk-internal#1419Raw changelog