Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Nov 28, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27184

📔 Objective

Changes the level of the SSO login email not found message from error to debug so that it doesn't cause confusino when collecting error messages from console logs for unrelated issues.

📸 Screenshots

Message displayed as shown below, only when isDev()

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Logo
Checkmarx One – Scan Summary & Detailsb1462c86-7305-42e8-8db4-5ab478b60bda

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2025-13224 Npm-electron-37.7.0
detailsRecommended version: 39.2.3
Description: Type Confusion in V8 in Google Chrome prior to 142.0.7444.175 allowed a remote attacker to potentially exploit heap corruption via a crafted HTML p...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: dGMUiNbgzBK7p8KvD2KLW%2B0oXrnQ9uwyLXPs%2FbjM73o%3D
Vulnerable Package

@trmartin4 trmartin4 marked this pull request as ready for review November 28, 2025 16:13
@trmartin4 trmartin4 requested a review from a team as a code owner November 28, 2025 16:13
@trmartin4 trmartin4 changed the title Update log level to debug Update "SSO login email not found" log level to debug Nov 28, 2025
@claude
Copy link

claude bot commented Nov 28, 2025

Claude finished @trmartin4's task —— View job


Code Review Complete

Summary

This PR correctly changes the log level from error to debug for the "SSO login email not found" message. The change is minimal, focused, and appropriately tested.

Findings

No findings - the changes look good.


Analysis

The changes are appropriate for the stated objective. The "SSO login email not found" scenario is not an error condition - it's an expected state in the normal login flow when SSO email is not present. Logging it as error would indeed cause confusion when reviewing logs for actual errors.

✅ The implementation is correct - both the service and test were updated consistently
✅ The test description on line 71 says "should log error and return early" but this is descriptive of the behavior (logging and early return), not the log level, so it's acceptable
✅ The change aligns with the PR objective and reduces log noise


@trmartin4 trmartin4 merged commit dd623b1 into main Dec 2, 2025
114 of 117 checks passed
@trmartin4 trmartin4 deleted the auth/pm-27184/sso-login-email-debug-level branch December 2, 2025 20:16
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.60%. Comparing base (a8d6ad4) to head (2e3a1a5).
⚠️ Report is 44 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17720      +/-   ##
==========================================
- Coverage   41.60%   41.60%   -0.01%     
==========================================
  Files        3553     3553              
  Lines      102390   102390              
  Branches    15366    15366              
==========================================
- Hits        42602    42601       -1     
  Misses      57995    57995              
- Partials     1793     1794       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants