[bitnami/grafana] don't error out on read-only config dir #77131
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marx <[email protected]>
enkore
force-pushed
the
grafana-configmap-support
branch
from
007675d to
75d67c5
Compare
carrodher
added
verify
|
Hi @enkore, Thanks for your contribution. I'm afraid I'm not fully understanding your changes. Can you provide us with an scenario in which this is required? Wouldn't this error prevent the initialization of Grafana due to missing configuration? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Errors when copying the example configuration files to the Grafana config dir are now ignored.
Benefits
The Grafana config dir as a whole or subdirectories may become read-only to the container, e.g. when mounting configmaps or secrets. Currently, these configurations require overwriting the entrypoint, which is undesirable.
Possible drawbacks