Skip to content

[bitnami/mysql] Optimize MYSQL_REPLICATION_SLAVE_DUMP behavior #76152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

[bitnami/mysql] Optimize MYSQL_REPLICATION_SLAVE_DUMP behavior #76152

wants to merge 20 commits into from

Conversation

mostafa-rz
Copy link
Contributor

Description of the change

  • Remove obtain and release the database lock
  • Remove finding binlog file name and current position
  • Add new options to the mysqldump
    • --single-transaction to dump consistent data
    • --quick to deal with large tables
    • --source-data=2 to add binlog file name and current position as a comment to the dump file

Benefits

The source database snapshot is consistent.

Applicable issues

@github-actions github-actions bot added mysql triage Triage is needed labels Jan 10, 2025
@github-actions github-actions bot requested a review from carrodher January 10, 2025 12:39
Mostafa Rouzbahani and others added 8 commits January 10, 2025 13:41
Signed-off-by: Mostafa Rouzbahani <[email protected]>

Signed-off-by: Mostafa Rouzbahani <[email protected]>
Signed-off-by: Mostafa Rouzbahani <[email protected]>

Signed-off-by: Mostafa Rouzbahani <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Mostafa Rouzbahani <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Mostafa Rouzbahani <[email protected]>
Signed-off-by: Mostafa Rouzbahani <[email protected]>
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@mostafa-rz
Copy link
Contributor Author

@carrodher Thanks for your response. I tried to fix it but I couldn't. I added Signed-off-by: Mostafa Rouzbahani [email protected]but it said it is wrong.

@carrodher
Copy link
Member

Did you follow the steps at https://github.com/bitnami/containers/pull/76152/checks?check_run_id=35432200911? There you can find some tips to rebase your signed commits on top of the main branch

@mostafa-rz
Copy link
Contributor Author

@carrodher can you pls remove this PR so I can open another one? I have some problem with my repo.

@mostafa-rz mostafa-rz closed this by deleting the head repository Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysql triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize MYSQL_REPLICATION_SLAVE_DUMP behavior
2 participants