Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/matomo] Added MATOMO_PROXY_IP_READ_LAST_IN_LIST env variable #73995

Closed

Conversation

ohheyrj
Copy link

@ohheyrj ohheyrj commented Oct 27, 2024

Description of the change

Added the MATOMO_PROXY_IP_READ_LAST_IN_LIST env variable which configures if Matomo should use the first or last IP in the list of IPs in the X-FORWARDED-FOR header. Default is 1 which means that the last IP is used.

Benefits

In my case, when using an ALB with Traefik, the IP address Matomo used for visitors was the last in the list which was always the internal IP address of the Traefik instance. This change means that users can configure this option to use the first IP in the list.

Possible drawbacks

No drawbacks, default option is the same as Matomo configures

Applicable issues

N/A

Additional information

N/A

Added the MATOMO_PROXY_IP_READ_LAST_IN_LIST env variable which configures if Matomo should use the first or last IP in the list of IPs in the X-FORWARDED-FOR header. Default is 1 which means that the last IP is used.

Signed-off-by: Richard Annand <[email protected]>
@github-actions github-actions bot added matomo triage Triage is needed labels Oct 27, 2024
@github-actions github-actions bot requested a review from javsalgar October 27, 2024 16:54
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Oct 28, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 28, 2024
@github-actions github-actions bot removed the request for review from javsalgar October 28, 2024 10:45
@github-actions github-actions bot requested a review from gongomgra October 28, 2024 10:45
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Nov 13, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
matomo solved stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants