Port Project to Python3.9 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharshman
force-pushed
the
port-python3_16
branch
from
56e12a2 to
e4994c9
Compare
OscarLuu
reviewed
Jan 12, 2024
| from assetman.parsers.django_parser import DjangoParser | ||
| return DjangoParser(template_path, settings) | ||
| print(template_type, template_path) | ||
| from assetman.parsers.tornado_parser import TornadoParser |
There was a problem hiding this comment.
Can we move this import to the top now since we don't need to dynamically import?
There was a problem hiding this comment.
Seems like the dynamic import might be there because there is a circular dependency between assetman/tools.py and assetman/parsers/tornado_parser.py
OscarLuu
reviewed
Jan 16, 2024
jharshman
force-pushed
the
port-python3_16
branch
from
32f93c9 to
a7e438a
Compare
Resolves: TS-2847
jharshman
force-pushed
the
port-python3_16
branch
from
6972fa1 to
2937b0b
Compare
jehiah
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port project to Python3.9
This PR ports this project to Python 3.9.