Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: add 346 (2025-03-21) #2228

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

harding
Copy link
Collaborator

@harding harding commented Mar 19, 2025

I might also add something about the testnet3 discussion on the ML, but I see AntoineP just started a related thread, so I'm inclined to let that stew for a few days and summarize it next week.

Comment on lines 16 to 17
of LND's recently-rewritten _sweeper_ system, which is responsible
determining what feerates to use for onchain transactions (including
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of LND's recently-rewritten _sweeper_ system, which is responsible
determining what feerates to use for onchain transactions (including
of LND's recently-rewritten _sweeper_ system, which
determines feerates to use for onchain transactions (including

(or, "is responsible for determining")

an external estimator) and ends with the total budget being allocated
to fees when the deadline is one block away."

He additionally describes how the new logic helps protected against
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
He additionally describes how the new logic helps protected against
He additionally describes how the new logic helps protect against

pinning].

He concludes with a link-filled summary of several "LND-specific bug
and vulnerability fixes" made though the improved logic. Abubakar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and vulnerability fixes" made though the improved logic. Abubakar
and vulnerability fixes" made through the improved logic. Abubakar

Comment on lines 55 to 56
LN implementations (in addition to other software) can make more
effective use of Bitcoin Core's fee estimation. Several other
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LN implementations (in addition to other software) can make more
effective use of Bitcoin Core's fee estimation. Several other
LN implementations (in addition to other software) can more
effectively use Bitcoin Core's fee estimation. Several other

@bitschmidty
Copy link
Contributor

Pushed client/services section (ignore that I called it the stack exchange segment!)

[Lightning BLIPs][blips repo], [Bitcoin Inquisition][bitcoin inquisition
repo], and [BINANAs][binana repo]._

- [Bitcoin Core #31649][] removes all checkpoint logic, replacing it with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"replacing it with" in this context sounds like this PR is replacing it, but really presync was a few years ago. Id suggest some slight rewording here @Gustavojfe

@harding
Copy link
Collaborator Author

harding commented Mar 20, 2025

Made edits for all feedback to my sections (thanks @LarryRuane @bitschmidty !), added lede, and added topic entries.

I deleted the releases/RCs section but then thought to check whether Bitcoin Core 29 RCs were available, which they are, so I'll add it back in an update later today.

Thanks everyone! I'll check back for additional review comments around 01:00 UTC.


Morehouse then describes how these two strategies are combined in
LND's new sweeper system: "[HTLC][topic htlc] claims with matching
deadlines [are aggregated] into a single [batched transaction][topic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[are aggregated]

Is this a dead link?

Copy link
Contributor

@jirijakes jirijakes Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are externally inserted words into the quote (I bet there is a term for it).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Adding those words there allowed us to save a bunch of words at the beginning of the quote. Sorry for the ambiguity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. thanks!

- [BTCPay Server #6581][] adds [RBF][topic rbf] support, enabling fee bumping
for transactions that have no descendants, where all inputs are from the
store’s wallet, and which include one of the store’s change addresses. Users
can now choose between [CPFP][topic cpfp] and RBF when choosing to fee bump a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
can now choose between [CPFP][topic cpfp] and RBF when choosing to fee bump a
can now choose between [CPFP][topic cpfp] and RBF when fee-bumping a

- [Bitcoin Core #31649][] removes all checkpoint logic, which is no longer
necessary following the headers presync step implemented years ago (see
Newsletter [#216][news216 presync]) that enables a node during Initial Block
Download (IBD) to determine if a chain of headers is valid by comparing its
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Download (IBD) to determine if a chain of headers is valid by comparing its
Download (IBD) to determine if a chain of headers may be valid by comparing its

Maybe, because otherwise it sounds like that's the only validity check that's needed.

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK lede, topics

@bitschmidty bitschmidty force-pushed the 2025-03-21-newsletter branch from c0ba735 to 3913c5d Compare March 21, 2025 13:19
@bitschmidty bitschmidty merged commit 009e707 into bitcoinops:master Mar 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants