docker: speed up building, improve documentation #2222
Merged
+24
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user must already have the repo cloned to use the Dockerfile, so don't clone it again. This speeds up the building process by avoiding unnecessary operations and improving caching.
Best practice is to combine apt-get update and apt-get install in one command to prevent caching issues. See https://docs.docker.com/build/building/best-practices/#apt-get
Elaborate a bit more on the fact that manually rebuilding is typically not necessary. Also remove the now deprecated docker-compose (V1) and replace it with docker compose (v2).
bitschmidty
reviewed
Mar 28, 2025
Yes, that was it indeed! I thought if I nuked the containers in the Docker GUI that would have forced a rebuild on future uses, but apparently not. Thanks! |
bitschmidty
approved these changes
Mar 31, 2025
azuchi
pushed a commit
to azuchi/bitcoinops.github.io
that referenced
this pull request
Apr 4, 2025
* docker: avoid unnecessary cloning The user must already have the repo cloned to use the Dockerfile, so don't clone it again. This speeds up the building process by avoiding unnecessary operations and improving caching. * docker: make caching more robust Best practice is to combine apt-get update and apt-get install in one command to prevent caching issues. See https://docs.docker.com/build/building/best-practices/#apt-get * docker: improve README Elaborate a bit more on the fact that manually rebuilding is typically not necessary. Also remove the now deprecated docker-compose (V1) and replace it with docker compose (v2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of improvements to avoid unnecessary operations and speed up building the container when previewing the website with Docker Compose. Rationale for each change is documented in the commit message.
cc @arshbot - thank you for your earlier work on adding docker support in #1540 !
Note: you'll have to rebuild your docker image for this PR:
docker compose down && docker compose up --build