Add option for sending Tx to specific peer in UI #208
+271
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1440000bytes
changed the title
luke-jr
requested changes
Oct 4, 2025
| @@ -0,0 +1,102 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Any reason we can't just use QInputDialog for this?
| }); | ||
| peersTableContextMenu->addSeparator(); | ||
| peersTableContextMenu->addAction(tr("&Disconnect"), this, &RPCConsole::disconnectSelectedNode); | ||
| peersTableContextMenu->addAction(tr("Send &Transaction"), this, &RPCConsole::sendTransactionToPeer); |
There was a problem hiding this comment.
Suggested change
| peersTableContextMenu->addAction(tr("Send &Transaction"), this, &RPCConsole::sendTransactionToPeer); | |
| peersTableContextMenu->addAction(tr("Send Raw &Transaction"), this, &RPCConsole::sendTransactionToPeer); |
| NodeId peerId = nodes.first().data().toLongLong(); | ||
|
|
||
| SendTransactionDialog dialog(platformStyle, this); | ||
| if (dialog.exec() == QDialog::Accepted) { |
There was a problem hiding this comment.
Suggested change
| if (dialog.exec() == QDialog::Accepted) { | |
| if (dialog.exec() != QDialog::Accepted) return; |
| return; | ||
| } | ||
|
|
||
| NodeId peerId = nodes.first().data().toLongLong(); |
There was a problem hiding this comment.
Seems like if multiple peers are selected, you would want to send to all of them?
|
|
||
| void RPCConsole::sendTransactionToPeer() | ||
| { | ||
| if (!clientModel) |
| QString txHex = dialog.getTransactionHex(); | ||
|
|
||
| if (!txHex.isEmpty()) { | ||
| QByteArray txBytes = QByteArray::fromHex(txHex.toUtf8()); |
There was a problem hiding this comment.
Shouldn't need UTF-8 for hex
Comment on lines
+1661
to
+1662
| QByteArray txBytes = QByteArray::fromHex(txHex.toUtf8()); | ||
| QString txHexForRpc = QString::fromUtf8(txBytes.toHex()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50