Skip to content

Conversation

Rob1Ham
Copy link

@Rob1Ham Rob1Ham commented Sep 8, 2025

This is a cherry pick of the commits from James O'Beirne's open PR into Bitcoin Core for BIP-348 (OP_CHECKSIGFROMSTACK)

Leaving this as a draft pull request for now as a reference.

This contains no activation code for mainnet, regtest only.

@justinfilip
Copy link

Delegate spend authority somewhere else off of L1.

@1440000bytes
Copy link

The commits in this PR look incorrect. Are you sure this is from bitcoin#32247?

@walkjivefly
Copy link

Not sure if this counts as "then they laugh at you," or "then they fight you," but it sounds like they're running scared.

@Rob1Ham
Copy link
Author

Rob1Ham commented Sep 9, 2025

The commits in this PR look incorrect. Are you sure this is from bitcoin#32247?

I was requested to make the same PR to another repo, and I didn't make a clean branch so it messed up this repo. Will fix now.

@Rob1Ham Rob1Ham force-pushed the v29.1.knots20250903-csfs branch from c3dd7cd to e88c9d2 Compare September 9, 2025 12:03
reardencode and others added 3 commits September 9, 2025 07:12
Some code and ideas from Elements by stevenroose, and sanket1729
Porting help from moonsettler.

Tests added to the transaction tests framework.

Co-authored-by: James O'Beirne <[email protected]>
(cherry picked from commit 15d7aa5)
@Rob1Ham Rob1Ham force-pushed the v29.1.knots20250903-csfs branch from e88c9d2 to 823b583 Compare September 9, 2025 12:14
@Rob1Ham
Copy link
Author

Rob1Ham commented Sep 9, 2025

@1440000bytes Should be good now

@average-gary
Copy link

Noting here that there is an example CTV/CSFS activation branch for testnet4 at https://github.com/average-gary/bitcoin-garrys-mod/tree/testnet4-ctv-csfs-activation

X-post from #178 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants