add tweak() method
#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xOnlyPointAddTweak, privateAdd, privateNegate
brandonblack
suggested changes
Jun 7, 2022
junderw
reviewed
Jun 8, 2022
brandonblack
approved these changes
Jun 8, 2022
junderw
approved these changes
Jun 12, 2022
|
I'll publish once bip32 is merged and we can publish together. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from this deprecated PR
Add the
tweak(t: Buffer): ECPairInterface;method toECPairInterfaceIt can tweak a
keyPairthat has aprivateKey, and also a keyPair where only thepublicKeyis present.The unit tests use the
tapTweakHash()function to create the tweak hash. This has several benefits: