Skip to content

Update electrsd to 0.33.0 #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

Update electrsd to 0.33.0 #120

merged 2 commits into from
Jul 14, 2025

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Mar 18, 2025 •
edited
Loading

Updates electrsd dev dependency to 0.33.0

Updated pinned deps needed to build on rust 1.63.0

fixes #119
fixes #117

@ValuedMammal ValuedMammal self-assigned this Mar 18, 2025
@coveralls
Copy link

coveralls commented Mar 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15977693055

Details

  • 131 of 131 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 86.919%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 3 95.44%
Totals Coverage Status
Change from base Build 15939070186: -0.7%
Covered Lines: 1010
Relevant Lines: 1162
💛 - Coveralls

@ValuedMammal ValuedMammal marked this pull request as ready for review March 18, 2025 17:33
@ValuedMammal ValuedMammal changed the title wip,deps: bump electrsd to 0.32 [deps] Update electrsd to 0.32 Mar 18, 2025
@ValuedMammal
Copy link
Contributor Author

For unit tests

  • using deserialize_hex instead of FromHex
  • add back AddressType::Legacy

@ValuedMammal ValuedMammal changed the title [deps] Update electrsd to 0.32 [deps] Update electrsd to 0.32.0 Mar 18, 2025
oleonardolima
oleonardolima reviewed Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0e02d79

oleonardolima
oleonardolima approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 0e02d79

It looks pretty straight-forward, with the two caveats of block_height and block_time fields.

oleonardolima
oleonardolima approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK e732a5b

@ValuedMammal
Copy link
Contributor Author

ACK e732a5b

@oleonardolima
Copy link
Collaborator

If we choose to release this one in 0.12.0, we can update it to bump electrsd to the latest 0.33.0; there are no new breaking changes, see oleonardolima@df610b0.

@ValuedMammal ValuedMammal changed the title [deps] Update electrsd to 0.32.0 [deps] Update electrsd to 0.33.0 Apr 17, 2025
@ValuedMammal ValuedMammal changed the title [deps] Update electrsd to 0.33.0 Update electrsd to 0.34.0 Jun 30, 2025
@ValuedMammal ValuedMammal changed the title Update electrsd to 0.34.0 Update electrsd to 0.33.0 Jun 30, 2025
@oleonardolima
Copy link
Collaborator

I saw that you bumped to 0.34.0 and reverted the changes, did that not work?

@ValuedMammal
Copy link
Contributor Author

Attempted to update electrsd to 0.34.0 but got blocked by CI. https://github.com/bitcoindevkit/rust-esplora-client/actions/runs/15977003057/job/45062009906

@oleonardolima
Copy link
Collaborator

Attempted to update electrsd to 0.34.0 but got blocked by CI. https://github.com/bitcoindevkit/rust-esplora-client/actions/runs/15977003057/job/45062009906

Got it, it's because the electrum-client got bumped to 0.23.1, which bumped the MSRV, in the latest 0.34.0.

oleonardolima
oleonardolima approved these changes Jul 4, 2025
View reviewed changes
Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cb6fdd2

@ValuedMammal ValuedMammal merged commit 482bc64 into bitcoindevkit:master Jul 14, 2025
25 checks passed
@ValuedMammal ValuedMammal deleted the deps/bump-electrsd branch July 14, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels
None yet
Projects
BDK Chain
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deps: Update dev-dependency electrsd to 0.32 [test] test_that_errors_are_propagated fails on Bitcoin Core v28.0
3 participants
@ValuedMammal @coveralls @oleonardolima