Skip to content

chore: use bitcoin::Amount instead of u64 on tests #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: use bitcoin::Amount instead of u64 on tests #223

wants to merge 1 commit into from

Conversation

luisschwab
Copy link
Member

Description

This PR simply updates tests to use bitcoin::Amount instead of u64.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@luisschwab
Copy link
Member Author

These clippy warnings get fixed by #213, I'll rebase once that's in.

@coveralls
Copy link

coveralls commented Apr 30, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14844399115

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.525%
Totals Coverage Status
Change from base Build 14766348168: 0.0%
Covered Lines: 7269
Relevant Lines: 8401
💛 - Coveralls

oleonardolima
oleonardolima reviewed May 5, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 114a94a

@ValuedMammal ValuedMammal added the api A breaking API change label May 7, 2025
@ValuedMammal ValuedMammal added this to the Wallet 2.0.0 milestone May 7, 2025
@ValuedMammal ValuedMammal moved this to Needs Review in BDK Wallet May 7, 2025
@ValuedMammal ValuedMammal added the tests New or improved tests label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima Awaiting requested review from oleonardolima

@ValuedMammal ValuedMammal Awaiting requested review from ValuedMammal

At least 1 approving review is required to merge this pull request.

Assignees

@luisschwab luisschwab

Labels
api A breaking API change tests New or improved tests
Projects
BDK Wallet
Status: Needs Review
Milestone
Wallet 2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@luisschwab @coveralls @oleonardolima @ValuedMammal