refactor(tests): move TxTemplate from chain to testenv

[tvpeter]

Description

This PR moves the TxTemplate from the chain crate into the testenv. It also updates the TxTemplate to use the Cow smart pointer, adds method implementations to TxTemplate, and migrates tests to the builder API.

This PR addresses the first and second todos on #1936.

Changelog notice

• moved TxTemplate from chain to testenv
• added builder API methods to TxTemplate

Checklists

All Submissions:

• I followed the contribution guidelines

[oleonardolima]

cACK a5d9f41

You can rebase to get the latest toolchain updated CI. Overall looks good, I only would like to take a deeper look into the last commit.

[oleonardolima]

cACK a5d9f41

You can rebase to get the latest toolchain updated CI. Overall looks good, I only would like to take a deeper look into the last commit.

Also, I'd avoid mixing renaming and moving code in the same commits.

[oleonardolima]

@tvpeter Oh, there are some conflicts 😅

[tvpeter]

@tvpeter Oh, there are some conflicts 😅

Yeah, from the recent merge. I will rebase and resolve

[oleonardolima]

@tvpeter I've rebased it on top of master to solve the conflicts, let me know if it's all good or I've messed something.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.65%. Comparing base (6d03fc3) to head (ee76753).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2177   +/-   ##
=======================================
  Coverage   78.65%   78.65%           
=======================================
  Files          30       30           
  Lines        5909     5909           
  Branches      279      279           
=======================================
  Hits         4648     4648           
  Misses       1185     1185           
  Partials       76       76           

Flag	Coverage Δ
rust	78.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

@tvpeter I've rebased it on top of master to solve the conflicts, let me know if it's all good or I've messed something.

At a glance, it looks just fine. Thank you.

[evanlinjin]

Remember that PR descriptions need to explain why things are done.

It also updates the TxTemplate to use the Cow smart pointe

What is the rationale for this?

Edit: I see that it is my suggestion in the ticket. I was wrong. Cow only makes sense if the type will start as a reference and may need to be mutated later on.

[tvpeter]

Edit: I see that it is my suggestion in the ticket. I was wrong. Cow only makes sense if the type will start as a reference and may need to be mutated later on.

Alright, should I revert the aspect that updates the TxTemplate struct using Cow?