Persist spks derived from KeychainTxOutIndex
#1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
force-pushed
the
feature/spk_cache
branch
4 times, most recently
from
7afd8b6 to
c279c99
Compare
evanlinjin
force-pushed
the
feature/spk_cache
branch
from
c279c99 to
d299dae
Compare
Thanks to @ValuedMammal for the suggestions
evanlinjin
force-pushed
the
feature/spk_cache
branch
from
90b6813 to
76875e7
Compare
* When merging changesets, assert that spk of a given descriptor id & derivation index does not get changed. * When reading spk from cache, check the spk by deriving it.
evanlinjin
force-pushed
the
feature/spk_cache
branch
from
fb838d9 to
d761265
Compare
This incentivies constructing `KeychainTxOutIndex` from a changeset before inserting descriptors (to make use of the spk cache).
evanlinjin
force-pushed
the
feature/spk_cache
branch
from
9d97b29 to
4bc8cc0
Compare
Also added staging changes to `ChangeSet::spk_cache`. This way, we can avoid returning `ChangeSet`s for `apply_changeset` and `insert_descriptor`. * `KeychainTxOutIndex::new` now takes in an additional `use_spk_cache` parameter. * Fixed `reveal_to_target` method to actually return `None` if the keychain does not exist.
evanlinjin
force-pushed
the
feature/spk_cache
branch
from
4bc8cc0 to
bbbc054
Compare
* `new` is now intended to construct a fresh indexed-tx-graph * `from_changeset` is added for constructing indexed-tx-graph from a previously persisted changeset * added `reindex` for calling after indexer mutations that require it * reintroduce `Default` impl
evanlinjin
force-pushed
the
feature/spk_cache
branch
from
bbbc054 to
3126cd2
Compare
evanlinjin
force-pushed
the
feature/spk_cache
branch
from
8fef7c7 to
603f133
Compare
3 tasks
ValuedMammal
requested changes
May 26, 2025
Do not reference last revealed table, in case none are revealed. Correct SQL column name.
|
|
notmandatory
approved these changes
May 27, 2025
There was a problem hiding this comment.
ACK 62767f0
tested with bdk-cli with cache enabled and sqlite schema updated and new table is being populated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1960
Fixes #1964
Description
Users with large wallet and/or complex descriptors may experience slow startup of
KeychainTxOutIndex. This PR addresses this problem by providing the option to persist derived spks so that they no longer need to be re-derived on startup.The
IndexedTxGraphAPI has been changed for better ergonomics.Compared to #1960, this is a more longterm solution that does not depend on multi-threading logic.
Changelog notice
Checklists
All Submissions:
cargo +nightly fmtandcargo clippybefore committingNew Features: