Skip to content

Conversation

tvpeter
Copy link
Collaborator

@tvpeter tvpeter commented Jun 5, 2025

Description

Fixes #199

Update README to show how to use just command runner to start, connect and fund your bdk-cli wallet with local bitcoind regtest node. Also, fixed clippy warnings.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@coveralls
Copy link

coveralls commented Jun 5, 2025

Pull Request Test Coverage Report for Build 15624082725

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 2.66%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers.rs 0 1 0.0%
src/utils.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 15508986518: -0.005%
Covered Lines: 25
Relevant Lines: 940

💛 - Coveralls

@tvpeter tvpeter requested a review from notmandatory June 7, 2025 14:29
tvpeter added 2 commits June 7, 2025 16:56
Update README to show how to use `just` to spine
up bitcoind in regtest mode, connect your bdk-cli
wallet and fund your bdk-cli wallet.

[issue: bitcoindevkit#199]
@tvpeter tvpeter force-pushed the docs/add-rpc-example branch from 9c4e9ff to b289a61 Compare June 7, 2025 15:57
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2524da3

I pushed an additional commit, if it looks OK to you feel free to merge the PR. Thanks for getting the build warnings fixed too.

Copy link
Collaborator Author

@tvpeter tvpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2524da3

Thank you for improving the formatting and steps.

@tvpeter tvpeter merged commit 85da2af into bitcoindevkit:master Jun 13, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this to Done in BDK-CLI Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add just example to show how to start and use the bdk-cli with the local regtest bitcoind
4 participants