-
Notifications
You must be signed in to change notification settings - Fork 75
Fix exit code #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix exit code #173
Conversation
@va-an, could you please rebase and confirm if the issue still exists; otherwise close the PR. Thank you for your efforts. |
@tvpeter, rebased to master. From master - exit code -> % cargo run --features electrum -- \
--network signet \
wallet \
--int-descriptor "" \
--client-type electrum \
--database-type sqlite \
--url some \
new_address
[2025-04-18T14:31:56Z ERROR bdk_cli] Generic error: An external descriptor is required.
-> % echo $?
0 With fix - exit code -> % cargo run --features electrum -- \
--network signet \
wallet \
--int-descriptor "" \
--client-type electrum \
--database-type sqlite \
--url some \
new_address
[2025-04-18T14:31:19Z ERROR bdk_cli] Generic error: An external descriptor is required.
-> % echo $?
1 |
Please let me know what I can do to make this PR ready to merge. |
Made a force-push to sign my commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 04c7f88
@va-an please rebase. |
Fix for #170.
I think this is the simplest way to do it.
It's also possible to change the main signature to return
Result
, which should provide similar behavior, but this option isn't compatible with the#[maybe_async]
macro, so I decided not to complicate things.