Skip to content

Add validate_domain Electrum option  #134

Closed

Description

@rajarshimaitra

Since bitcoindevkit/bdk@8d4cc39 bdk opens the validate_domain option in electrum config. We should also expose it via bdk-cli electrum options.

Activity

  1. Rahamath-unnisa commented on Oct 9, 2025

    @Rahamath-unnisa

    Hi! 👋
    I’d like to work on this issue and expose the validate_domain option in bdk-cli for Electrum.
    Could I take this up?

  2. tvpeter commented on Oct 9, 2025

    @tvpeter
    Collaborator

    Hi! 👋 I’d like to work on this issue and expose the validate_domain option in bdk-cli for Electrum. Could I take this up?

    Yes, you can

  3. Rahamath-unnisa commented on Oct 9, 2025

    @Rahamath-unnisa
  4. tvpeter commented on Oct 9, 2025

    @tvpeter
    Collaborator

    I wasn’t able to locate the CLI file (electrum.rs or similar) in the repo.
    Could you point me to where it is, or how I can find it?

    Hello Rahamath,
    It’s essential to understand the project before seeking to take on an issue. Please review our contribution guidelines for first timers here. In the meantime, I will unassign the issue. Thank you.

  5. Rahamath-unnisa commented on Oct 20, 2025

    @Rahamath-unnisa

    Hi 👋,

    I’ve studied the codebase and the contribution guidelines, made the necessary modifications to expose the validate_domain option in bdk-cli, and tested it locally.
    Here is the Pull Request: PR #223
    Looking forward to your review!
    Thanks

  6. tvpeter commented on Apr 1, 2026

    @tvpeter
    Collaborator

    Closing this issue with this comment

  7. moved this from Todo to Done in BDK-CLIon Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    • Status
      Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions