wallet: derivehdkey RPC to get xpub at arbitrary path #32784
Conversation
DrahtBot
changed the title
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32784. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
Sjors
force-pushed
the
2025/06/gethdkey
branch
2 times, most recently
from
de7f5c6 to
3f35b02
Compare
src/rpc/util.h
Outdated
| @@ -152,6 +152,14 @@ std::pair<int64_t, int64_t> ParseDescriptorRange(const UniValue& value); | |||
| /** Evaluate a descriptor given as a string, or as a {"desc":...,"range":...} object, with default range of 1000. */ | |||
| std::vector<CScript> EvalDescriptorStringOrObject(const UniValue& scanobject, FlatSigningProvider& provider, const bool expand_priv = false); | |||
|
|
|||
| //! Get extended key and origin info for a given path | |||
| //! @params[in] path The BIP 32 path | |||
There was a problem hiding this comment.
In util.h: “@params[in] path” → “@param[in] path” [Doxygen tag typo]
doc/multisig-tutorial.md
Outdated
| ``` | ||
|
|
||
| The `<0;1>` notation in `desc` caused the creation of two descriptors. One uses the chain 0 for external addressesd the other the chain 1 for internal ones (change). |
There was a problem hiding this comment.
addressesd -> addresses [extra “d” makes “addresses” misspelled]
|
Very nice, Concept ACK. |
unused() descriptors do not have scriptPubKeys. Instead, the wallet uses them to store keys without having any scripts to watch for.
Use derivehdkey instead of extracting each participant xpub (and derivation info) from the listdescriptors output. Additionally use the new <0;1> descriptor syntax. Finally this commits adds a few debug log lines, and expand the explanation for why we use m/44h/1h/0h.
Use derivehdkey instead of extracting each participant xpub from the listdescriptors output. Additionally use the new <0;1> descriptor syntax. Also use bitcoin rpc instead of bitcoin-cli.
Given a (blank) wallet with an
unused(KEY)descriptor,derivehdkey "m/87h/0h/0h"gets the xpub or xpriv at any given path.This is particularly useful for multisig setup where it's not desirable to use our default derivations (e.g. 44h).
I updated the multisig tutorial and the functional test.
Based on:
addhdkeyRPC to add just keys to wallets via newunused(KEY)descriptor #29136