Skip to content

Add eclair support #2 #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add eclair support #2 #724

wants to merge 11 commits into from

Conversation

macgyver13
Copy link
Contributor

@macgyver13 macgyver13 commented Jun 19, 2025 •
edited
Loading

This PR adds eclair support to warnet and sim-ln

Notes:

  • upgrade sim-ln plugin to 0.2.4 for eclair support
  • pin eclair docker image to 0.11.0 version - address persistent crash with 0.12.0+ (secp256k1_der_parse_integer+0x166)
  • eclair 0.11.0 requires bitcoin core 27.2+ (tested with 28.1 and 29.0)
  • enable txindex on bitcoin core
  • support switching zmqblock format on bitcoin core node - eclair and lnd require different format
  • now LNNode instances can be used in test with common syntax between ln nodes
    • newaddress
    • nodeid
    • uri
    • walletbalance
    • channelbalance
    • connect
    • channel
    • createinvoice
    • payinvoice
    • graph

Breaking change (bitcoincore chart dependencies):

previous

ln:
  lnd: true
lnd:
  channels:

proposed

lnd:
  enabled: true
  channels:

@macgyver13
Add eclair support to simln plugin - upgrade to 0.2.4
234137e 
override network graph check for eclair nodes
pin eclair docker image to 0.11.0 version
enable keysend feature for eclair
handle new enabled scheme for ln nodes
conditional enable wallets for eclair nodes
update documentation to use new ln node enable scheme
@macgyver13
fix format
06e4366
@macgyver13
fix fee rate calculation assumptions for eclair channels
3238e64
@macgyver13

This comment was marked as outdated.

Sign in to view
@pinheadmz
Copy link
Contributor

eclair_multi.zip

can you add eclair to one of our existing tests? or add a new 3-implementation interop test?

@pinheadmz
Copy link
Contributor

I cherry-picked the lint fix to main, if you wanna rebase to run ci

macgyver13 added 6 commits July 2, 2025 14:30
@macgyver13
Merge branch 'main' into add-eclair
d56b880 
* main:
  Fix Python 3.9 compatibility: replace match statement with if/elif
  admin scenarios access logs
@macgyver13
correct lnd node syntax graph::import-network
efb2deb
@macgyver13
remove fixme
d509de0
@macgyver13
fix logging test - enable lnd to satisfy metric
4aadc52 
fix proc exception, add --debug command support
@macgyver13
reverse capture_output change
8291e7e
@macgyver13
add support for testing LNNode through rpc
4a109cf 
add new ln_mixed_test
add support for switching zmqblock format on bitcoin core node
@macgyver13
Copy link
Contributor Author

eclair_multi.zip

can you add eclair to one of our existing tests? or add a new 3-implementation interop test?

added ln_mixed_test

@macgyver13 macgyver13 marked this pull request as ready for review July 9, 2025 02:49
@pinheadmz
Copy link
Contributor

I got a bunch of errors running ln_mixed_test locally: https://gist.github.com/pinheadmz/2525b9672944516857811b97d6ae7072

Looks mostly like the rune wasn't in place at the right time?

@macgyver13
Copy link
Contributor Author

I got a bunch of errors running ln_mixed_test locally: https://gist.github.com/pinheadmz/2525b9672944516857811b97d6ae7072

Looks mostly like the rune wasn't in place at the right time?

Commit fdbaf71 adds CLN startup probe. Let me know if you have better results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macgyver13 @pinheadmz