Skip to content

proxy-types: prevent race condition when reading client.m_context.connection #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ViniciusCestarii wants to merge 1 commit into from
Closed

proxy-types: prevent race condition when reading client.m_context.connection #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion include/mp/proxy-types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,14 @@ struct CapRequestTraits<::capnp::Request<_Params, _Results>>
template <typename Client>
void clientDestroy(Client& client)
{
if (client.m_context.connection) {
// Lock because m_context.connection can be cleared concurrently by the
// disconnect cleanup callback (see addSyncCleanup on ProxyClientBase constructor).
bool connected;
{
Lock lock{client.m_context.loop->m_mutex};
connected = client.m_context.connection != nullptr;
}
if (connected) {
MP_LOG(*client.m_context.loop, Log::Debug) << "IPC client destroy " << CxxTypeName(client);
} else {
KJ_LOG(INFO, "IPC interrupted client destroy", CxxTypeName(client));
Expand Down
Loading