Add RSS and Twitter favicons #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. I think it looks fine on a monitor, but a bit messy on a narrow display like a phone screen:
|
Make it easier to see channels to stay up to date on new review clubs etc. New icons can easily be added by updating _data/social-media.yml.
|
I've switched the order of the elements so the icons keep floating above the title on narrow screens. This looks better, right?
|
|
Looks good to me. utACK b7497c0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #625, implementing jnewbery's suggestion to include favicons for our Twitter and Atom feed on the site header.
My jekyll and frontend skills are minimal, so I'm very open to suggestions on implementing this in a cleaner way, although I think it's fairly maintainable as is. To edit the icons, one can just update
_data/social-media.yml.