feat: Check if Include folders/files do exists (in case they are removed)

[rafaelhdr]

Solution b) when start taking a snapshot the include list should be checked of existence first and warn about missings.

reference: #1586

[rafaelhdr]

This is not complete yet, but if possible I would like some feedback before finishing it.

Are the messages good? And I am wondering if the qt warning is ok (it is asking a confirmation before continuing instead of just warning).

And I didn't implement a) for no big reason. I am still getting familiar with the code and b) was something that was more clear for me. I could try a) in a future PR.

And how you normally do translations? I was planning to translate all other languages using some automated tool (Copilot) but I wanted to confirm how you guys do it normally...

[buhtz]

Dear Rafael,
Awesome! Thank you for this next contribution.

I added some comments and suggestions to the code. I am not sure about the whole solution. I would suggest to further discuss it in the related issue #1586.

I will set the PR into Draft mode to state the the solution is not finished.

Best,
Christian

[rafaelhdr]

I appreciate a lot for the review. It clarified a lot of questions and taught me some good lessons (I would never have thought about RTL issues on translations). And I am happy about not use the camel case :)

I will do the fixes from the review and wait for any suggestion in the original issue.

Thank you very much 🙏

[buhtz]

Does anyone know how to trigger the systray-icon message-bubbles via BIT?

I tried with "Snapshot.setTakeSnapshotMessage(1, 'FOO BAR')" but without success. This message appears in the status bar of the main window.

[buhtz]

I would never have thought about RTL issues on translations

Me neither. When I started to work on the translation task I thougt it is easy. I learned things like that from translators and the community around them while trying to attract translators to BIT.

[rafaelhdr]

Ooooh my bad 🤦‍♂️

When I saw the message, I understood wrong (that we merged this to dev)

[buhtz]

OK, lets move on. The 1.5.4 release is out and now the road is free to work on this PR. I am doing some testing and reviewing ...

I am just doing some notes here.

That is the current message

Maybe better: Warning: The following files or directories from the include list are missing in the backup source.

• User callback
• Regex pattern in include list Pattern in include list not supported.

[rafaelhdr]

Hello,

I see you already made some changes that you suggested.
I don't know if I should still work on it (and that is fine... I think your changes are good, and it is faster to do these small changes than review and ask me to do it)

But I think you forgot to uncomment some warnings.

Aside that, it seems all good :)

[buhtz]

Yep, I am not finished yet. That is why I set the PR back into "Draft" mode. I was just reviewing the code, doing some minor modifications and then the modifications become bigger and bigger. ;)
But it does not modify the behavior of your original PR. It is simply about code structure and naming. I am still not sure how the final solution might look like.

New warning message

[buhtz]

Now I am figuring out the user-callback user case.

For the CLI version it seems to work. The missing-include-check is executed after the user-callback script was called with reason 7.

But this does not happen when doing the check in the GUI.

I don't know how to handle this. The original Snapshots.backup() code is very complex. It seems we need to do ìn the GUI something like this:

1. mount.Mount().mount()
2. config.PLUGIN_MANAGER.processBegin() (this seems to invoked the user-callback with reason 7)
3. do the include-missing-check
4. config.PLUGIN_MANAGER.processEnds()
5. mount.Mount().umount()

What is your opinion on that?

[rafaelhdr]

Sorry, I don't have a good opinion on that :(

I am very new in the project, and last time I touched it was several months ago. I don't think I would be able to help.

[buhtz]

Sorry, I don't have a good opinion on that :(

That is OK. Then we will try and see. 😄