Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connectivity offline lib #10

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add connectivity offline lib #10

wants to merge 10 commits into from

Conversation

leonardo2204
Copy link
Contributor

Sorry for the long list, the lint was complaining about a lot of stuff, so I needed to fix before commiting!

@leonardo2204 leonardo2204 mentioned this pull request Aug 10, 2018
Open
birkir
birkir requested changes Aug 15, 2018
View reviewed changes
Copy link
Owner

@birkir birkir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks.

Can you lock in the dependency, and also this project does not use prettier, it's hard to review pull requests that are just changing non related code formatting

@leonardo2204
Copy link
Contributor Author

@birkir done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkir birkir birkir requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonardo2204 @birkir