fix(core): don't build control flow graph inside bogus nodes #4963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
arendjr
changed the title
CodSpeed Performance ReportMerging #4963 will not alter performanceComparing Summary
|
unvalley
pushed a commit
to unvalley/biome
that referenced
this pull request
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4723 by adding a
BogusVisitorto our control flow graph builder. The original panic was caused by a broken assumption due to the presence of a bogus statement between the if statement and its else clause. I think the safer alternative is to just skip bogus branches from analysis.To aid with this, codegen now generate an
Any*BogusNodefor every language as well.Test Plan
Added test case.