Fix pytorch_state_dict import from library #378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PyTorchModelAdaptor
passes asha256
keyword to the callable responsible for instantiating the model:core-bioimage-io-python/bioimageio/core/model_adapters/_pytorch_model_adapter.py
Line 107 in ff8af21
If the callable is an
ArchitectureFromLibraryDescr
, then an error will be raised since there is nokwargs
in the function signature:core-bioimage-io-python/bioimageio/core/digest_spec.py
Line 64 in ff8af21
Fix
Add
kwargs
to the function signature (and that of other callables).core-bioimage-io-python/bioimageio/core/digest_spec.py
Line 65 in 7681ab7
SIde note
The pre-commit hooks forced me to fix an import, is it due to me not having the right version of the specs?
core-bioimage-io-python/bioimageio/core/digest_spec.py
Line 23 in 7681ab7