-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logstash rework #52
Logstash rework #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an function for clearing logs.
Add an API for accessing the records without the asserts and also I think you should provide a context manager for assert logs and assert no logs, similar to unittest. |
Co-authored-by: Ben Avrahami <[email protected]>
Co-authored-by: Ben Avrahami <[email protected]>
Co-authored-by: Ben Avrahami <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 87.89% 88.33% +0.43%
==========================================
Files 13 13
Lines 694 797 +103
Branches 64 78 +14
==========================================
+ Hits 610 704 +94
- Misses 58 65 +7
- Partials 26 28 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Docs + Tests underway.
Looking for a review on the interface and if any changes are requested before I make this pretty.