fix(tool): update rand crate to the latest version #216
Conversation
crates/binjs_generic/src/pick.rs
Outdated
| json::from(string) | ||
| } | ||
| TypeSpec::Number => { | ||
| json::from(rng.next_f64()) | ||
| json::from(rng.next_u64()) |
There was a problem hiding this comment.
Hey, I want f64, not u64 :)
There was a problem hiding this comment.
sadly, that was removed
There was a problem hiding this comment.
This seems to suggest that there's still a way, no?
There was a problem hiding this comment.
Okayes, let me do it differently.
rng.gen::<f64>() would do
yarn.lock
Outdated
| @@ -0,0 +1,362 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
Wait, why is this updating yarn.lock?
There was a problem hiding this comment.
my yarn version is different, this should not be here I will remove it
| .clone() | ||
| // rng.choose(&[Identity, Gzip, /* Deflate is apprently broken https://github.com/alexcrichton/flate2-rs/issues/151 , */ Brotli /*, Lzw doesn't work yet */]) | ||
| // .unwrap() |
There was a problem hiding this comment.
Could you remove that code instead of commenting it out?
tests/test_roundtrip.rs
Outdated
| let float = rng.next_f64(); | ||
| float < CHANCES_TO_SKIP | ||
| fn should_skip(rng: &mut RngCore) -> bool { | ||
| let float = rng.next_u64(); |
There was a problem hiding this comment.
Same problem of f64 :)
Since CHANCES_TO_SKIP <= 1, by using next_u64, you're effectively skipping only if your result is 0, which happens roughly 1/2^64 times, i.e. never :)
|
Could you:
|
sendilkumarn
force-pushed
the
rand-update
branch
from
177d90d to
16f34d3
Compare
remove yarn lock file use sliceRandom instead of deprecated choose method remove yarn lock clean and move u64 to f64 rng fix test roundtrip
sendilkumarn
force-pushed
the
rand-update
branch
from
16f34d3 to
b391855
Compare
|
@Yoric Done 👍 There are a lot of changes in the rand crate, took a little time to get it. |
|
Feel free to merge when you're ready! |
|
I don't have write access 😢 |
Fixes a part of #165