feat(cli): add domains claim command for cross-store domain ownership#3084
Open
jorgemoya wants to merge 1 commit into
Open
feat(cli): add domains claim command for cross-store domain ownership#3084jorgemoya wants to merge 1 commit into
jorgemoya wants to merge 1 commit into
Conversation
Add `catalyst domains claim <domain>` so users can claim ownership of a custom domain that is already in use on another store. Publishing the ownership-verification TXT record and then claiming releases the domain from the other store and binds it to the current project. The Domains API returns the TXT record in the `meta.ownership_verification` field of a cross-store collision. Surface it as a typed DomainOwnershipVerificationError so both `domains add` (on a 409 collision) and `domains claim` (on a 422 unverified claim) print the record and the next step instead of an opaque error. Refs LTRAC-1106 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 6d780bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
Contributor
Author
|
Testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: LTRAC-1106
What/Why?
The
catalyst domains claimcommand was missed from the initial Native Hosting CLI work. It lets a user claim ownership of a custom domain that is already in use on another store/project — publish the ownership-verification TXT record, then runclaimto release the domain from the other store and bind it to the current project (POST .../projects/{project_uuid}/domains/{domain}/claim).The Domains API returns the TXT record to publish in the
meta.ownership_verificationfield of a cross-store collision. Rather than let it surface as an opaque error, it's parsed into a typedDomainOwnershipVerificationErrorso:domains add— on a409cross-store collision, prints the TXT record plusThen run: catalyst domains claim <domain>.domains claim— on a422not-yet-verified claim, reprints the TXT record so the user can publish it and retry.claimmirrorsadd/status: after a successful claim it shows the domain status, and--waitpolls until the domain leavespendingverification.Docs (CLI reference + native-hosting getting-started) are updated in a separate
docs-v2change.Testing
pnpm --filter @bigcommerce/catalyst test src/cli/commands/domains.spec.ts(31 passing), pluspnpm typecheckandpnpm lint. New coverage:claimDomainsuccess +422verification error, theclaimcommand (success, unverified TXT reprint,--wait), and theaddcross-store collision path. Verifiedcatalyst domains claim --helpon the built CLI.Migration
None.