Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 45b8257 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle Size ReportComparing against baseline from
Per-Route First Load JS
|
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
|
Is there no way to trigger a request or something to obtain this information after we select a country? I don't know if I like putting "Optional" text when it's not really optional. Also, the error message has |
|
@parthshahp Yeah I don't love how its says optional when required for a country with states i'll update. I matched validation to cart. I can add a conditional render of the field, but it will require changes to the dynamic form and this would be the only field that would do this. On your second point, I think thats out of scope since thats how all errors are being displayed. stateOrProvince comes from the backend and if we were to make this look better it would make sense to change all server error messages. If this is something you want I can make a separate ticket for it. |
|
@parthshahp Ready for another review |
Jira: TRAC-291
What/Why?
The Account Registration form validated State/Province as required even when the selected country has no states (Algeria, Monaco, etc.).
The register page now queries per-country state data from BigCommerce. When the shopper picks a country with no states, the State/Province field is hidden entirely and validation skips it. When the country does have states, the field stays visible and required.
Testing
Tested locally against an integration store:
Migration
None. No changes to server-side behavior or data model.