Week02

[bigben5616]

First and foremost I have not used a pull request before and this is the first time using a pull request. From my research I have found out more what a pull request actually is. A pull request is a generally used part of the process in development of software between a person making a change to some part of code and a reviewer on the team that will review and hopefully approve the changes made. A pull request lets you tell other people on github about a change you have pushed to a branch in a repository. Once a pull request is opened you and your team can discuss and review the potential changes with collaborators and add follow-up commits before your changes are merged to the base branch.

After initializing a pull request, you can see a review page that shows a high-level overview of the changes between your branch and the repositories base branch. You can also add a summary of the proposed changes, review the changes made by commits, add labels, milestones and assignees. You can also add @ and mention a team member to contribute or call out for certain items. Once you have created a pull request, you can push commits from your topic branch to add them to your existing pull request. These commits will appear in chronological order within your pull request and the changes will be visible in the "Files changed" tab.

Other contributors can review your proposed changes, add review comments, contribute to the pull request discussion, and even add commits to the pull request. After you are happy with the proposed changes, you can merge the pull request. I you are working on a shared repository model, you create a pull request and you, or someone else will merge your changes from your feature branch into the base branch you specify in your pull request.

The changes being made involve adding in arrays, slices and maps into my code in order to create different lists and form a better understanding of the difference between all three. I ran into a few difficulties which include, I was unsure how to set up an empty act variable for the code. I read through all of the notes and there was no mention of an empty act variable, I even looked it up and couldnt find any information in regards to this. Due to my not sure how to set up the empty act variable I was also a little confused how to copy the values into the act variable and how to iterate through the act variable and assert that its contents match that of the exp variable. I went through all of the notes and tried to understand how to implement these concepts into the code and I just followed the example problems to interpret how to do it for the specific task at hand. In addition, I spent time researching and leaning more on my own.

I was surprised to see that the file tests.yml that I implemented in did not work even though I copied the code in the assignment into my assignment on github. I was also surprised that the tests.yml code was used against windows, macOS and linux machines instead of just one of the machines.

[bigben5616]

The second commit (57596d1) is the correct one.