Basic Kobo Support #101
Basic Kobo Support #101
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 7911963 | Triggered | Generic Password | f2aed59 | docker-compose.yml | View secret |
| 7911963 | Triggered | Generic Password | f2aed59 | docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
ragusa87
force-pushed
the
main
branch
8 times, most recently
from
0fbfb8f to
c1b9a6e
Compare
| return; | ||
| } | ||
| list($originalWidth, $originalHeight) = $sizes; | ||
|
|
There was a problem hiding this comment.
why not use imaginebundle?
There was a problem hiding this comment.
We can discuss this, but it seems complicated to me.
- Echo Device can ask for different size
- I don't think it's usefull to store theses covers
- I have no idea how to integreate imagineBundle to resize "on the fly".
ragusa87
force-pushed
the
main
branch
2 times, most recently
from
3e8f136 to
5cce470
Compare
|
closed because merge in another pr |
ignored-pathsconfiguration option GitGuardian/ggshield#548) so I rebased the MR without theses files.