add pytest coverage library and add sample_index coverage

bgunnar5 · Dec 11, 2023 · f10c896 · f10c896
1 parent 38651f2
commit f10c896
Show file tree

Hide file tree

Showing 4 changed files with 508 additions and 170 deletions.
diff --git a/.gitignore b/.gitignore
@@ -39,8 +39,9 @@ flux.out
 slurm*.out
 docs/build/
 
-# Tox files
+# Test files
 .tox/*
+.coverage
 
 # Jupyter
 jupyter/.ipynb_checkpoints

diff --git a/merlin/common/sample_index.py b/merlin/common/sample_index.py
@@ -225,8 +225,8 @@ def __setitem__(self, full_address, sub_tree):
 
         # Replace if we already have something at this address.
         if delete_me is not None:
-            self.children.__delitem__(full_address)
             SampleIndex.check_valid_addresses_for_insertion(full_address, sub_tree)
+            self.children.__delitem__(full_address)
             self.children[full_address] = sub_tree
             return
         raise KeyError

diff --git a/requirements/dev.txt b/requirements/dev.txt
@@ -5,6 +5,7 @@ dep-license
 flake8
 isort
 pytest
+pytest-cov
 pylint
 twine
 sphinx>=2.0.0
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,6 +5,7 @@ dep-license @@
     flake8
     isort
     pytest
+    pytest-cov
     pylint
     twine
     sphinx>=2.0.0
@@ Expand Down @@