fix(database): serialize incident creation per server#155
Merged
Conversation
Two concurrent event pushes against different issues on the same server could each insert a fresh incident row, leaving two open incidents for one server. The per-issue FOR UPDATE on the issue row doesn't help — the two events lock different issue rows. Take a FOR UPDATE lock on the root server's row at the top of find_or_open_incident so the find-or-create pair serializes per-server. Belt-and-braces backstop at the DB layer: promote the existing partial index on incidents (server_id) WHERE closed_at IS NULL to UNIQUE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code