fix(database): dedupe incident_issues pairs in Incident::stats_for#152
Merged
Conversation
incident_issues is keyed on (incident_id, issue_id, joined_at), so an issue that leaves and rejoins the same incident produces multiple rows for the same pair. The previous count_star() queries multiplied the issue count by the rejoin count and multiplied events/issue_notes by the rejoin factor on top. Pull distinct (incident_id, issue_id) pairs first, then count events and notes per issue, summing back per incident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
incident_issuesis keyed on(incident_id, issue_id, joined_at), so an issue that leaves and rejoins the same incident produces multiple rows for the same pair.Incident::stats_forwas counting those rows directly:issue_count = count_star()overincident_issues→ counted rejoin rows, not distinct issues.event_countjoinedeventstoincident_issuesonissue_idandcount_star()'d, so every event row was multiplied by the number of rejoin rows for its(incident, issue)pair.note_count'sissue_noteshalf had the same multiplier.On a real incident this surfaced as 9021 issues and 59M events when
sum(occurrences) from eventswas 48288 — i.e. wildly impossible numbers.The fix pulls distinct
(incident_id, issue_id)pairs first, then counts events /issue_notesper issue and sums back per incident.incident_notesis unaffected and still runs concurrently with the other queries.