Crashes on startup due to too many bindings

[BenjaminBrienen]

Bevy version

c03e494: Migrate reflection benchmarks to new naming system (#16986) …

[Optional] Relevant system information

PS C:\Users\BenjaminBrienen\source\bevy> cargo version                                                                                                                                                                              
cargo 1.83.0 (5ffbef321 2024-10-29)

SystemInfo { os: "Windows 11 Pro", kernel: "26100", cpu: "12th Gen Intel(R) Core(TM) i7-12700H", core_count: "14", memory: "31.7 GiB" }

AdapterInfo { name: "Intel(R) Iris(R) Xe Graphics", vendor: 32902, device: 18086, device_type: IntegratedGpu, driver: "Intel Corporation", driver_info: "101.6325", backend: Vulkan }

My drivers are very up-to-date.

What you did

PS C:\Users\BenjaminBrienen\source\bevy> cargo run --example testbed_ui --no-default-features --features "android-game-activity android-game-activity android_shared_stdcxx animation bevy_asset bevy_audio bevy_color bevy_core_pipeline bevy_gilrs bevy_gizmos bevy_gltf bevy_mesh_picking_backend bevy_pbr bevy_picking bevy_remote bevy_render bevy_scene bevy_sprite bevy_sprite_picking_backend bevy_state bevy_ui bevy_ui_picking_backend bevy_window bevy_winit custom_cursor default_font hdr multi_threaded png smaa_luts sysinfo_plugin tonemapping_luts vorbis webgl2 x11"

What went wrong

warning: error finalizing incremental compilation session directory `\\?\C:\Users\BenjaminBrienen\source\bevy\target\debug\incremental\bevy_gltf-3d0vzuikmb2aw\s-h33e87o7fs-12utzwx-working`: Access is denied. (os error 5)

warning: `bevy_gltf` (lib) generated 1 warning
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.84s
     Running `target\debug\examples\testbed_ui.exe`
2024-12-26T21:32:35.430861Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows 11 Pro", kernel: "26100", cpu: "12th Gen Intel(R) Core(TM) i7-12700H", core_count: "14", memory: "31.7 GiB" }
2024-12-26T21:32:35.592957Z  INFO bevy_render::renderer: AdapterInfo { name: "Intel(R) Iris(R) Xe Graphics", vendor: 32902, device: 18086, device_type: IntegratedGpu, driver: "Intel Corporation", driver_info: "101.6325", backend: Vulkan }
2024-12-26T21:32:36.498821Z ERROR wgpu::backend::wgpu_core: Handling wgpu errors as fatal by default    
thread 'main' panicked at C:\Users\BenjaminBrienen\.cargo\registry\src\index.crates.io-6f17d22bba15001f\wgpu-23.0.1\src\backend\wgpu_core.rs:891:18:
wgpu error: Validation Error

Caused by:
  In Device::create_bind_group_layout, label = 'StandardMaterial'
    Too many bindings of type Samplers in Stage ShaderStages(VERTEX | FRAGMENT), limit is 64, count was 96. Check the limit `max_samplers_per_shader_stage` passed to `Adapter::request_device`


note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\examples\testbed_ui.exe` (exit code: 101)

Additional information

Encountered in #16322

[BenjaminBrienen]

This also happens with trying to run loading_screen

[mockersf]

Can't reproductible on a Mac.

Could you try to git bisect?

[BenjaminBrienen]

#16644

7ed1f327d91a73b3c96f306ae15e53bcc39192f3 is the first bad commit
commit 7ed1f327d91a73b3c96f306ae15e53bcc39192f3 (HEAD)
Author: Patrick Walton <[email protected]>
Date:   Tue Dec 10 09:48:56 2024 -0800

    Make `StandardMaterial` bindless. (#16644)

[BenjaminBrienen]

@pcwalton Do you think you could continue the investigation from here? It has to do with the bindless StandardMaterial.

[pcwalton]

Well, the error is quite clear, unfortunately: we have too many samplers. I suppose what we should probably do is to check the max sampler count and if it’s too high for the material, disable bindless for that material. Varying the chunk size isn’t really an option right now because wgpu presently requires all binding arrays to have fixed size specified in the shader.