Skip to content

Commit dbb2fcb

Browse files
Re-enable test_property_type_registration() (#4419)
# Objective - This test was mysteriously commented out ## Solution - Re-enable it - Also done in #4299, but this is better as its own PR.
1 parent cf831d5 commit dbb2fcb

File tree

1 file changed

+33
-33
lines changed

1 file changed

+33
-33
lines changed

crates/bevy_reflect/src/type_registry.rs

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,7 @@ impl<T: for<'a> Deserialize<'a> + Reflect> FromType<T> for ReflectDeserialize {
353353
#[cfg(test)]
354354
mod test {
355355
use crate::TypeRegistration;
356+
use bevy_utils::HashMap;
356357

357358
#[test]
358359
fn test_get_short_name() {
@@ -390,37 +391,36 @@ mod test {
390391
);
391392
}
392393

393-
// TODO: re-enable
394-
// #[test]
395-
// fn test_property_type_registration() {
396-
// assert_eq!(
397-
// TypeRegistration::of::<Option<f64>>().short_name,
398-
// "Option<f64>"
399-
// );
400-
// assert_eq!(
401-
// TypeRegistration::of::<HashMap<u32, String>>().short_name,
402-
// "HashMap<u32, String>"
403-
// );
404-
// assert_eq!(
405-
// TypeRegistration::of::<Option<HashMap<u32, String>>>().short_name,
406-
// "Option<HashMap<u32, String>>"
407-
// );
408-
// assert_eq!(
409-
// TypeRegistration::of::<Option<HashMap<u32, Option<String>>>>().short_name,
410-
// "Option<HashMap<u32, Option<String>>>"
411-
// );
412-
// assert_eq!(
413-
// TypeRegistration::of::<Option<HashMap<String, Option<String>>>>().short_name,
414-
// "Option<HashMap<String, Option<String>>>"
415-
// );
416-
// assert_eq!(
417-
// TypeRegistration::of::<Option<HashMap<Option<String>, Option<String>>>>().short_name,
418-
// "Option<HashMap<Option<String>, Option<String>>>"
419-
// );
420-
// assert_eq!(
421-
// TypeRegistration::of::<Option<HashMap<Option<String>, (String, Option<String>)>>>()
422-
// .short_name,
423-
// "Option<HashMap<Option<String>, (String, Option<String>)>>"
424-
// );
425-
// }
394+
#[test]
395+
fn test_property_type_registration() {
396+
assert_eq!(
397+
TypeRegistration::of::<Option<f64>>().short_name,
398+
"Option<f64>"
399+
);
400+
assert_eq!(
401+
TypeRegistration::of::<HashMap<u32, String>>().short_name,
402+
"HashMap<u32, String>"
403+
);
404+
assert_eq!(
405+
TypeRegistration::of::<Option<HashMap<u32, String>>>().short_name,
406+
"Option<HashMap<u32, String>>"
407+
);
408+
assert_eq!(
409+
TypeRegistration::of::<Option<HashMap<u32, Option<String>>>>().short_name,
410+
"Option<HashMap<u32, Option<String>>>"
411+
);
412+
assert_eq!(
413+
TypeRegistration::of::<Option<HashMap<String, Option<String>>>>().short_name,
414+
"Option<HashMap<String, Option<String>>>"
415+
);
416+
assert_eq!(
417+
TypeRegistration::of::<Option<HashMap<Option<String>, Option<String>>>>().short_name,
418+
"Option<HashMap<Option<String>, Option<String>>>"
419+
);
420+
assert_eq!(
421+
TypeRegistration::of::<Option<HashMap<Option<String>, (String, Option<String>)>>>()
422+
.short_name,
423+
"Option<HashMap<Option<String>, (String, Option<String>)>>"
424+
);
425+
}
426426
}

0 commit comments

Comments
 (0)