Skip to content

Commit cd8560c

Browse files
removed optional bevy_time dependency from bevy_gizmos
1 parent 0495ae7 commit cd8560c

File tree

5 files changed

+16
-20
lines changed

5 files changed

+16
-20
lines changed

crates/bevy_app/src/main_schedule.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,13 @@ pub struct RunFixedUpdateLoop;
7474
#[derive(ScheduleLabel, Clone, Debug, PartialEq, Eq, Hash)]
7575
pub struct FixedUpdate;
7676

77+
/// Indicates that [`RunFixedUpdateLoop`] is currently active.
78+
#[derive(Resource)]
79+
pub struct FixedUpdateScheduleIsCurrentlyRunning {
80+
/// Sequentially increasing with each fixed update.
81+
pub update: u64,
82+
}
83+
7784
/// The schedule that contains app logic.
7885
/// This is run by the [`Main`] schedule.
7986
#[derive(ScheduleLabel, Clone, Debug, PartialEq, Eq, Hash)]

crates/bevy_gizmos/Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ keywords = ["bevy"]
1010

1111
[features]
1212
webgl = []
13-
fixed_update = ["dep:bevy_time"]
1413

1514
[dependencies]
1615
# Bevy
@@ -26,4 +25,3 @@ bevy_core = { path = "../bevy_core", version = "0.12.0-dev" }
2625
bevy_reflect = { path = "../bevy_reflect", version = "0.12.0-dev" }
2726
bevy_core_pipeline = { path = "../bevy_core_pipeline", version = "0.12.0-dev" }
2827
bevy_transform = { path = "../bevy_transform", version = "0.12.0-dev" }
29-
bevy_time = { path = "../bevy_time", version = "0.12.0-dev", optional = true }

crates/bevy_gizmos/src/gizmos.rs

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
33
use std::{f32::consts::TAU, iter};
44

5+
use bevy_app::FixedUpdateScheduleIsCurrentlyRunning;
56
use bevy_ecs::{
67
component::Tick,
78
system::{Resource, SystemBuffer, SystemMeta, SystemParam},
@@ -82,17 +83,9 @@ const _: () = {
8283
type Item<'w, 's> = Gizmos<'s>;
8384

8485
fn init_state(world: &mut World, _system_meta: &mut SystemMeta) -> Self::State {
85-
#[cfg(not(feature = "fixed_update"))]
86-
let fixed_time_tick = None;
87-
#[cfg(feature = "fixed_update")]
88-
let fixed_time_update =
89-
if world.contains_resource::<bevy_time::fixed_timestep::FixedUpdateScheduleIsCurrentlyRunning>() {
90-
world
91-
.get_resource::<bevy_time::prelude::FixedTime>()
92-
.map(|time| time.times_expended())
93-
} else {
94-
None
95-
};
86+
let fixed_time_update = world
87+
.get_resource::<FixedUpdateScheduleIsCurrentlyRunning>()
88+
.map(|current| current.update);
9689
Wrap(GizmoBuffer {
9790
fixed_time_update,
9891
list_positions: default(),

crates/bevy_internal/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,4 +139,4 @@ bevy_text = { path = "../bevy_text", optional = true, version = "0.12.0-dev" }
139139
bevy_ui = { path = "../bevy_ui", optional = true, version = "0.12.0-dev" }
140140
bevy_winit = { path = "../bevy_winit", optional = true, version = "0.12.0-dev" }
141141
bevy_gilrs = { path = "../bevy_gilrs", optional = true, version = "0.12.0-dev" }
142-
bevy_gizmos = { path = "../bevy_gizmos", optional = true, version = "0.12.0-dev", default-features = false, features = ["fixed_update"] }
142+
bevy_gizmos = { path = "../bevy_gizmos", optional = true, version = "0.12.0-dev", default-features = false }

crates/bevy_time/src/fixed_timestep.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
//! variants for game simulation, but rather use the value of [`FixedTime`] instead.
2323
2424
use crate::Time;
25-
use bevy_app::FixedUpdate;
25+
use bevy_app::{FixedUpdate, FixedUpdateScheduleIsCurrentlyRunning};
2626
use bevy_ecs::{system::Resource, world::World};
2727
use bevy_utils::Duration;
2828
use thiserror::Error;
@@ -99,10 +99,6 @@ impl Default for FixedTime {
9999
}
100100
}
101101

102-
/// Indicates that [`run_fixed_update_schedule`] is currently active.
103-
#[derive(Resource)]
104-
pub struct FixedUpdateScheduleIsCurrentlyRunning;
105-
106102
/// An error returned when working with [`FixedTime`].
107103
#[derive(Debug, Error)]
108104
pub enum FixedUpdateError {
@@ -115,7 +111,9 @@ pub enum FixedUpdateError {
115111

116112
/// Ticks the [`FixedTime`] resource then runs the [`FixedUpdate`].
117113
pub fn run_fixed_update_schedule(world: &mut World) {
118-
world.insert_resource(FixedUpdateScheduleIsCurrentlyRunning);
114+
world.insert_resource(FixedUpdateScheduleIsCurrentlyRunning {
115+
update: world.resource::<FixedTime>().times_expended(),
116+
});
119117

120118
// Tick the time
121119
let delta_time = world.resource::<Time>().delta();

0 commit comments

Comments
 (0)