Skip to content

Commit 8f85d4e

Browse files
authored
rendering regression: mention in pr comment that the solution could be to update the pr (#18153)
# Objective - When a PR gets merged that modifies the rendering screenshots, the main reference will be updated - Every in-flight PR will then "fail" rendering change detection as they come from an outdated main branch ## Solution - Suggest updating the PR to the latest main branch
1 parent 19ee692 commit 8f85d4e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/example-run-report.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,5 +104,5 @@ jobs:
104104
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
105105
run: |
106106
LF=$'\n'
107-
COMMENT_BODY="Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! ${LF}You can review it at https://pixel-eagle.com/project/$PROJECT?filter=PR-$PR ${LF} ${LF}If it's expected, please add the M-Deliberate-Rendering-Change label."
107+
COMMENT_BODY="Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! ${LF}You can review it at https://pixel-eagle.com/project/$PROJECT?filter=PR-$PR ${LF} ${LF}If it's expected, please add the M-Deliberate-Rendering-Change label. ${LF} ${LF}If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it."
108108
gh issue comment $PR --body "$COMMENT_BODY"

0 commit comments

Comments
 (0)