Skip to content

Commit 54ff7aa

Browse files
Bump notify to 5.0.0-pre.11 (#2564)
# Objective notify 5.0.0-pre.11 breaks the interface again, but apparently in a way that's similar to how it used to be ## Solution Bump `bevy_asset` dependency on notify to `5.0.0-pre.11` and fix the errors that crop up. It looks like `pre.11` was mentioned in #2528 by @mockersf but there's no mention of why `pre.10` was chosen ultimately.
1 parent 155068a commit 54ff7aa

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

crates/bevy_asset/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ crossbeam-channel = "0.5.0"
3232
anyhow = "1.0.4"
3333
thiserror = "1.0"
3434
downcast-rs = "1.2.0"
35-
notify = { version = "=5.0.0-pre.10", optional = true }
35+
notify = { version = "=5.0.0-pre.11", optional = true }
3636
parking_lot = "0.11.0"
3737
rand = "0.8.0"
3838

crates/bevy_asset/src/filesystem_watcher.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ pub struct FilesystemWatcher {
1212
impl Default for FilesystemWatcher {
1313
fn default() -> Self {
1414
let (sender, receiver) = crossbeam_channel::unbounded();
15-
let watcher: RecommendedWatcher = Watcher::new_immediate(move |res| {
15+
let watcher: RecommendedWatcher = RecommendedWatcher::new(move |res| {
1616
sender.send(res).expect("Watch event send failure.");
1717
})
1818
.expect("Failed to create filesystem watcher.");
@@ -22,6 +22,6 @@ impl Default for FilesystemWatcher {
2222

2323
impl FilesystemWatcher {
2424
pub fn watch<P: AsRef<Path>>(&mut self, path: P) -> Result<()> {
25-
self.watcher.watch(path, RecursiveMode::Recursive)
25+
self.watcher.watch(path.as_ref(), RecursiveMode::Recursive)
2626
}
2727
}

0 commit comments

Comments
 (0)