Skip to content

Commit 28d2b34

Browse files
committed
Avoid windows with a physical size of zero
1 parent 8783fae commit 28d2b34

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

crates/bevy_pbr/src/light.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -793,12 +793,16 @@ pub(crate) fn assign_lights_to_clusters(
793793
}
794794

795795
let clusters = clusters.into_inner();
796-
let screen_size = camera.target.get_physical_size(&windows, &images);
796+
let screen_size =
797+
if let Some(screen_size) = camera.target.get_physical_size(&windows, &images) {
798+
screen_size
799+
} else {
800+
continue;
801+
};
797802

798803
clusters.aabbs.clear();
799804
clusters.lights.clear();
800805

801-
let screen_size = screen_size.unwrap_or_default();
802806
let mut requested_cluster_dimensions = config.dimensions_for_screen_size(screen_size);
803807

804808
let view_transform = camera_transform.compute_matrix();

crates/bevy_render/src/camera/camera.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ impl RenderTarget {
7979
UVec2::new(width, height)
8080
}),
8181
}
82+
.filter(|size| size.x > 0 && size.y > 0)
8283
}
8384
pub fn get_logical_size(&self, windows: &Windows, images: &Assets<Image>) -> Option<Vec2> {
8485
match self {
@@ -312,8 +313,8 @@ pub fn extract_cameras<M: Component + Default>(
312313
ExtractedView {
313314
projection: camera.projection_matrix,
314315
transform: *transform,
315-
width: size.x.max(1),
316-
height: size.y.max(1),
316+
width: size.x,
317+
height: size.y,
317318
near: camera.near,
318319
far: camera.far,
319320
},

0 commit comments

Comments
 (0)