-
Notifications
You must be signed in to change notification settings - Fork 381
Replace Fira font with variable version #1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
doup
wants to merge
1
commit into
bevyengine:main
Choose a base branch
from
doup:variable-font
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,69 +1,21 @@ | ||
| /* fira-sans-300 - latin */ | ||
| @font-face { | ||
| @font-face { | ||
| font-family: "Fira Sans"; | ||
| font-display: swap; | ||
| font-weight: 100 900; | ||
| font-style: normal; | ||
| font-weight: 300; | ||
| src: url("/assets/fonts/fira-sans-v10-latin-300.eot"); /* IE9 Compat Modes */ | ||
| src: local("Fira Sans Light"), local("FiraSans-Light"), | ||
| url("/assets/fonts/fira-sans-v10-latin-300.eot?#iefix") format("embedded-opentype"), /* IE6-IE8 */ | ||
| url("/assets/fonts/fira-sans-v10-latin-300.woff2") format("woff2"), /* Super Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-300.woff") format("woff"), /* Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-300.ttf") format("truetype"), /* Safari, Android, iOS */ | ||
| url("/assets/fonts/fira-sans-v10-latin-300.svg#FiraSans") format("svg"); /* Legacy iOS */ | ||
| src: local("Firava"), | ||
| url("/assets/fonts/firava-sans.woff2") format("woff2 supports variations"), | ||
| url("/assets/fonts/firava-sans.woff2") format("woff2-variations"), | ||
| url("/assets/fonts/firava-sans.ttf") format("truetype-variation"); | ||
| } | ||
|
|
||
| /* fira-sans-regular - latin */ | ||
| @font-face { | ||
| font-family: "Fira Sans"; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| src: url("/assets/fonts/fira-sans-v10-latin-regular.eot"); /* IE9 Compat Modes */ | ||
| src: local("Fira Sans Regular"), local("FiraSans-Regular"), | ||
| url("/assets/fonts/fira-sans-v10-latin-regular.eot?#iefix") format("embedded-opentype"), /* IE6-IE8 */ | ||
| url("/assets/fonts/fira-sans-v10-latin-regular.woff2") format("woff2"), /* Super Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-regular.woff") format("woff"), /* Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-regular.ttf") format("truetype"), /* Safari, Android, iOS */ | ||
| url("/assets/fonts/fira-sans-v10-latin-regular.svg#FiraSans") format("svg"); /* Legacy iOS */ | ||
| } | ||
|
|
||
| /* fira-sans-italic - latin */ | ||
| @font-face { | ||
| @font-face { | ||
| font-family: "Fira Sans"; | ||
| font-display: swap; | ||
| font-weight: 100 900; | ||
| font-style: italic; | ||
| font-weight: 400; | ||
| src: url("/assets/fonts/fira-sans-v10-latin-italic.eot"); /* IE9 Compat Modes */ | ||
| src: local("Fira Sans Italic"), local("FiraSans-Italic"), | ||
| url("/assets/fonts/fira-sans-v10-latin-italic.eot?#iefix") format("embedded-opentype"), /* IE6-IE8 */ | ||
| url("/assets/fonts/fira-sans-v10-latin-italic.woff2") format("woff2"), /* Super Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-italic.woff") format("woff"), /* Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-italic.ttf") format("truetype"), /* Safari, Android, iOS */ | ||
| url("/assets/fonts/fira-sans-v10-latin-italic.svg#FiraSans") format("svg"); /* Legacy iOS */ | ||
| } | ||
|
|
||
| /* fira-sans-500 - latin */ | ||
| @font-face { | ||
| font-family: "Fira Sans"; | ||
| font-style: normal; | ||
| font-weight: 500; | ||
| src: url("/assets/fonts/fira-sans-v10-latin-500.eot"); /* IE9 Compat Modes */ | ||
| src: local("Fira Sans Medium"), local("FiraSans-Medium"), | ||
| url("/assets/fonts/fira-sans-v10-latin-500.eot?#iefix") format("embedded-opentype"), /* IE6-IE8 */ | ||
| url("/assets/fonts/fira-sans-v10-latin-500.woff2") format("woff2"), /* Super Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-500.woff") format("woff"), /* Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-500.ttf") format("truetype"), /* Safari, Android, iOS */ | ||
| url("/assets/fonts/fira-sans-v10-latin-500.svg#FiraSans") format("svg"); /* Legacy iOS */ | ||
| } | ||
|
|
||
| /* fira-sans-800 - latin */ | ||
| @font-face { | ||
| font-family: "Fira Sans"; | ||
| font-style: normal; | ||
| font-weight: 800; | ||
| src: url("/assets/fonts/fira-sans-v10-latin-800.eot"); /* IE9 Compat Modes */ | ||
| src: local("Fira Sans ExtraBold"), local("FiraSans-ExtraBold"), | ||
| url("/assets/fonts/fira-sans-v10-latin-800.eot?#iefix") format("embedded-opentype"), /* IE6-IE8 */ | ||
| url("/assets/fonts/fira-sans-v10-latin-800.woff2") format("woff2"), /* Super Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-800.woff") format("woff"), /* Modern Browsers */ | ||
| url("/assets/fonts/fira-sans-v10-latin-800.ttf") format("truetype"), /* Safari, Android, iOS */ | ||
| url("/assets/fonts/fira-sans-v10-latin-800.svg#FiraSans") format("svg"); /* Legacy iOS */ | ||
| src: local("Firava Italic"), | ||
| url("/assets/fonts/firava-sans-italic.woff2") format("woff2 supports variations"), | ||
| url("/assets/fonts/firava-sans-italic.woff2") format("woff2-variations"), | ||
| url("/assets/fonts/firava-sans-italic.ttf") format("truetype-variation"); | ||
| } | ||
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is intentional in order to show the text as quickly as possible, over the default of
autofor which some user agents may block longer?Generally I'm biased towards
autofor stuff like this but I thinkswapis reasonable and doesn't critically override user preference, unless their browser usesfallbackfor crappy internet connections or something like that. But the font files are really small so I wouldn't be that worried about it.